search

getappmap / appmap-ruby

AppMap client agent for Ruby
https://appland.org
Other
98 stars 11 forks source link

Enhance Thread and Fiber Safety in ActiveRecordExaminer #353

Closed coderberry closed 4 months ago

coderberry commented 4 months ago

Attempt to fix #349

~This PR fixes this issue by wrapping the Fiber that is accessing the connection pool with a temporary "root" Fiber. Once the query has completed, the fiber will be terminated and the connection will be returned to the pool.~

This PR is at a state where a fix can be applied and tested, but the implemented fix is not correct.

coderberry commented 4 months ago

@swrobel Would you mind reviewing this PR and provide any feedback or insights? I learned a LOT from following you around in GitHub issues and discussions.

coderberry commented 4 months ago

@dividedmind thank you for your feedback. I forgot to flag this PR as a draft. Tests and a better description are coming 🙌🏻

And yes, the description was created by ChatGPT. I planned on updating it, along with adding tests and inline docs before it's ready for final review. I wanted to make this code available early for any feedback such as yours. 👍