search

getappmap / scanner

Code scanning, linting, assertions and alerts.
Other
0 stars 0 forks source link

fix: Better error message if AppLand server is not configured #112

Closed dividedmind closed 2 years ago

dividedmind commented 2 years ago

In cases where eg. API key is not configured, the message said that online features would be skipped, but then the scan failed anyway. New message correctly says to use --all to proceed offline.

dividedmind commented 2 years ago

@kgilpin or is it supposed to fail? The test (that now fails) and the warning message say different things.

kgilpin commented 2 years ago

I think maybe we should change the doc rather than the app behavior. It would seem too strange to me as a user if the app behavior depends on whether I have an API key in my environment or not.

appland-release commented 2 years ago

:tada: This PR is included in version 1.46.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: