search

getappmap / scanner

Code scanning, linting, assertions and alerts.
Other
0 stars 0 forks source link

fix: Only process a couple appmaps at a time #87

Closed dividedmind closed 2 years ago

dividedmind commented 2 years ago

Previously the scan command tried to open all the appmaps found at the same time. This not only hurt performance but could also lead to a hard error due to exhaustion of available file descriptors.

I originally hit it while trying to process all of saleor's thousands of appmaps.

dividedmind commented 2 years ago

Good idea. Are you interested in using queue from the async library?

We are using it in appmap-js.

Ah, good idea; I wasn't sure if there was anything like this already in dependencies so I rolled my own (not like it's complicated). Although actually eachLimit from that library looks more appropriate.

dividedmind commented 2 years ago

Actually async isn't used in scanners yet. Not sure if it's worth bringing it in for such a simple purpose.

kgilpin commented 2 years ago

I understand not bringing in too many packages but I think this one is worthwhile.

That way future developer can read their doc to understand the code and how it might be extended / modified.

On Sun, Jan 23, 2022 at 8:11 PM Rafał Rzepecki @.***> wrote:

Actually async isn't used in scanners yet. Not sure if it's worth bringing it in for such a simple purpose.

— Reply to this email directly, view it on GitHub https://github.com/applandinc/scanner/pull/87#issuecomment-1019622185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC6ZHCK2LL45FX5OZDQDUXSRKNANCNFSM5MP6OK2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because your review was requested.Message ID: @.***>

appland-release commented 2 years ago

:tada: This PR is included in version 1.36.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: