search

getappmap / vscode-appland

AppLand extension for VSCode
MIT License
142 stars 16 forks source link

VS Code users appear not to be updating #590

Closed dustinbyrne closed 1 year ago

dustinbyrne commented 1 year ago

End-user dependencies seem to have a long lag time between updates. This should not be the case. Updates (if available) should be fetched upon initialization.

The install/update process is defined here: https://github.com/getappmap/vscode-appland/blob/master/src/services/nodeProcessService.ts#L129

symwell commented 1 year ago

A potential issue is that spawn forks a process that doesn't necessarily complete by the time the call to spawn returns. The await in front of spawn is unnecessary, according to vscode (there are three ...s under await), and perhaps misleading.

await_spawn

If this is the issue, it means yarn up doesn't complete by the time appmap-win-x64.exe is executed.

edit: I think this isn't true. I assume the installProcess.once('exit', handler setup later waits until the process exits.

appland-release commented 1 year ago

:tada: This issue has been resolved in version 0.61.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: