search

getappmap / vscode-appland

AppLand extension for VSCode
MIT License
135 stars 14 forks source link

Prompt Python and Java users to install AppMap into mappable project #698

Closed Daniel-Warner-X closed 1 year ago

Daniel-Warner-X commented 1 year ago

When a user opens a mappable Ruby project that does not have AppMap installed they see this:

Image

We want the same behavior for users who have AppMap installed into VS Code and who open a mappable Java or Python project.

This commit shows how this was done for Ruby/Rails; we just need similar criteria matching for suitable Java and Python projects. Some useful test projects to clone to test this include: Java: https://github.com/spring-projects/spring-petclinic Java: https://github.com/Azure-Samples/tomcat10-jakartaee9 Python: https://github.com/django-oscar/django-oscar Python: https://github.com/chicagopython/chipy.org Python: https://github.com/flaskbb/flaskbb Python: https://github.com/jainamoswal/Flask-Example

When this feature is implemented correctly, a user with the AppMap VS Code extension installed will get a similar message box notification when they first open any of those projects, offering to install AppMap into the project.

dividedmind commented 1 year ago

It appears it has been done on purpose in https://github.com/getappmap/vscode-appland/commit/69f9936b7640c4e6c9bd22615284321324011ada — however, the commit message sadly lacks any rationale. @dustinbyrne , do you remember why it was done?

dustinbyrne commented 1 year ago

We were originally testing the prompt solely with Rails users to see how it converted.

dustinbyrne commented 1 year ago

Should this issue hold off until we've implemented some of the installer QoL fixes?

kgilpin commented 1 year ago

I have this already on a branch

dividedmind commented 1 year ago

We were originally testing the prompt solely with Rails users to see how it converted.

Are you sure? The aforementioned commit limits it to Rails — it seems it used to had worked universally before.

kgilpin commented 1 year ago

@brikelly @dustinbyrne I feel like we may as well roll this out for Python + Java users now.

brikelly commented 1 year ago

Agreed, let's get this one done

appland-release commented 12 months ago

:tada: This issue has been resolved in version 0.101.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: