Immediate version info update on CBLoader

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0

MIT License

218 stars 48 forks source link

Immediate version info update on CBLoader #339

Closed davidlatwe closed 5 years ago

davidlatwe commented 6 years ago

Before:

cbloader_before

The change of version in subset view, require re-select subset so the version widget will update.

After:

cbloader_after

Now the version widget will update immediately with reasonable database query counts. You can scroll the version list and view comments smoothly.

Minor tweak

Supporting unicode comments.
Version widget will expanded by default.

mottosso commented 6 years ago

Nice one David. I've added write permissions to you, so you can assign a label and request a review from e.g. @BigRoy. You're able to merge as well, just bear in mind to let everyone get a chance to see a PR first, at least 24 hours since the last commit.

davidlatwe commented 6 years ago

Big thanks @mottosso ! I'll keep that in mind :D

BigRoy commented 6 years ago

David, this is sweet. Thanks!

I actually am working on another "version widget" that shows all comments, bu this is already great. Nice job.

BigRoy commented 6 years ago

Looks good to me, feel free to merge.

davidlatwe commented 5 years ago

Merging this :) Thanks @mottosso @BigRoy !