Workfiles API redefines built-in `open`

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0

MIT License

218 stars 48 forks source link

Workfiles API redefines built-in `open` #407

Closed jasperges closed 4 years ago

jasperges commented 5 years ago

The Worfiles API redefines the built-in open. That's bad practice and if you're not careful it may lead to issues. Maybe it would be better to rename it to open_file or something like this?

https://github.com/getavalon/core/blob/master/avalon/tools/workfiles/app.py#L362 https://github.com/getavalon/core/tree/master/avalon/tools/workfiles#implementing-a-new-host-integration-for-work-files

Every workio.py file for the hosts should then be updated as well.

BigRoy commented 5 years ago

I'm fine with refactoring it. Thanks for spotting it and pointing it out.