getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
218 stars 48 forks source link

Pymongo collections.save() is deprecated #411

Closed BigRoy closed 5 years ago

BigRoy commented 5 years ago

Issue

The avalon.io module exposes save() from Pymongo Collections, however this seems to be deprecated in favor of replace_one and insert_one.

Adding this issue here to ensure we're aware of this deprecation and have any features we implement use replace_one and insert_one moving forward.

We currently have replace_one and insert_one exposed via avalon.io too, so it's recommended to use those. :)


Note that we'll need to swap out save in the inventory functions too:

davidlatwe commented 5 years ago

I know this one 🙋‍♂ . In the use case of inventory, I think we should change to use replace_one.