getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
214 stars 48 forks source link

Remerge app.py #429

Closed mottosso closed 4 years ago

mottosso commented 4 years ago

388 mistakenly merged the wrong app.py for the new loader. See https://github.com/getavalon/core/pull/426#issuecomment-523377949

@davidlatwe At first glance, this appears to be working, however the style doesn't appear to work, and I'm not sure why? :S

Before

image

After

image

mottosso commented 4 years ago

These are both running Loader from outside of Maya, e.g.

python -m avalon --loader
davidlatwe commented 4 years ago

I just checked-out your branch. and.. No matter I launcher Loader inside or outside of Maya, all failed to reproduce it 0.0

davidlatwe commented 4 years ago

The only difference (compare to the commit before 388) I spotted was this line, it's from #393 here, the last missing piece.

- assets = AssetWidget()
+ assets = AssetWidget(silo_creatable=False)
mottosso commented 4 years ago

Ok, I can confirm this only happens with PySide2-5.13, and does not happen with..

Very strange, but probably nothing we need to worry about.

mottosso commented 4 years ago

The only difference (compare to the commit before 388) I spotted was this line, it's from #393 here, the last missing piece.

Sorry, missed this. Pushed this directly to master just now.