search

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
218 stars 49 forks source link

Implement#179 #444

Closed davidlatwe closed 5 years ago

davidlatwe commented 5 years ago

This PR resolve #179. But instead of changing subset QLineEdit widget's background color, I chose to use border-color for better UX on text editing.

What's changed?

Demo GIF (outdated, see comment below)

creator

BigRoy commented 5 years ago

Sweet! :)

Just wondering whether we can improve on this slightly further. I checked with an artist and asked "what do you think this orange/green highlighting means"? His reply was that he thought he orange line meant he must've typed symbols or characters that are invalid which unfortunately isn't what we're trying to state with the orange border. As such, we should somehow clarify what the coloring means or show it differently to the user.

Some ideas:

  1. Add a tooltip so that when the Artists hovers over it at least he understands what's up. However, not everyone will do this and it might still be missed.
  2. Maybe adding icons could help clarify what is up, e.g. a refresh kind of symbol when it overwrites and a plus when it's a completely new one. Again, this could still be misinterpreted.
  3. Maybe instead of orange we can pick a color that indicates slightly less danger?
  4. The artist mentioned it would be clearer to him if the Creator would show a message on the moment when you're trying to create it. E.g. "This subset has already been published for this asset before. Are you sure you want to generate publishes that will publish new versions for it? Yes/no?" -> Most clear, but a bit interuptive. Not the biggest fan of it, but it describes how clear it hopefully would be in the end as to what it's doing.
tokejepsen commented 5 years ago

Just wondering whether we can improve on this slightly further. I checked with an artist and asked "what do you think this orange/green highlighting means"? His reply was that he thought he orange line meant he must've typed symbols or characters that are invalid which unfortunately isn't what we're trying to state with the outline. As such, we should somehow clarify what the coloring means or show it differently to the user.

Hadn't read the issue and just saw the GIF and had the same thoughts as the artist.

The artist mentioned it would be clearer to him if the Creator would show a message on the moment when you're trying to create it. E.g. "This subset has already been published for this asset before. Are you sure you want to generate publishes that will publish new versions for it? Yes/no?" -> Most clear, but a bit interuptive. Not the biggest fan of it, but it describes how clear it hopefully would be in the end as to what it's doing.

Maybe inform the user in the status bar, where it currently says "Ready"?

davidlatwe commented 5 years ago

Here's the changed demo :) I though a bluish color may be a good fit, since both scenario are acceptable actions, so just picking another color that does not have the impression of danger. And improve the indication by the echo message.

creator