search

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
218 stars 49 forks source link

Expose the "loader" column in Scene Inventory #455

Closed BigRoy closed 5 years ago

BigRoy commented 5 years ago

This implements a fix for #454 so that it's visible to the artist which Loader is being used for specific loaded content directly within the Scene Inventory.

This implements solution option 1) as presented in the issue. It's a very minor change in code. :)

BEFORE

before

AFTER

after

mottosso commented 5 years ago

Oo, that is nice. 👍

davidlatwe commented 5 years ago

What about putting the loader name inside the family column with margin ? Looks like they could be merged together.

BigRoy commented 5 years ago

What about putting the loader name inside the family column with margin ? Looks like they could be merged together.

  1. It would complicate the code more than it currently does.
  2. Additionally it disallows sorting either on Family or on Loader type.
  3. It even allows to hide the "Loader" column if you wouldn't care about it and don't want to show it.

It offers less features with more complexity and I personally don't have an issue with it being a column of its own. As such, I personally wouldn't merge the two columns.

davidlatwe commented 5 years ago

It would complicate the code more than it currently does.

Yeah, good point, just found out that this PR only modified one line. Now I could not bare to complicate it for that, too.

BigRoy commented 5 years ago

just found out that this PR only modified one line.

It was definitely more trivial than I expected. 😄

mkolar commented 5 years ago

great!