getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
213 stars 48 forks source link

Implement Nuke's `lib.read` #476

Closed davidlatwe closed 4 years ago

davidlatwe commented 4 years ago

Motivation

The Avalon data read-write methods implemented in Nuke was driven by prefixing knob name so to differ which knob is node's default and which is user-defined.

But the prefix may change, and the logic was not the same as other hosts, so if there's a way to differ user-defined and default knobs without prefixing knob name, I think we should opt that in.

Changes

davidlatwe commented 4 years ago

Just patched my motivation in above comment :point_up:

And, in the following GIF you may see the difference between divider and text knob, the string knob and read-only string knob.

knobs

Note that the string knob with nuke.READ_ONLY applied, user still able to select and copy string, but not with text knob.

tokejepsen commented 4 years ago

Looks good! Nice work @davidlatwe

davidlatwe commented 4 years ago

This will be merged tomorrow if no other objections :rocket: