search

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
213 stars 48 forks source link

Travis CI check failed on reporting coverage #492

Closed davidlatwe closed 4 years ago

davidlatwe commented 4 years ago

What happened ?

The module coverage updated to version 5.0 yesterday, but python-coveralls seems not yet adopted. Which leads to https://travis-ci.org/getavalon/core/builds/625677709#L556

coverage has dropped the Reporter base class since coverage-5.0a6, but the latest python-coveralls still importing it here.

Solution

In /Dockerfile-maya2016

  1. Pin coverage version to 4.5.4. OR
  2. Remove coverage from pip install list and replace python-coveralls with coveralls, because coveralls already took care and pinned the version of coverage it needs here. python-coveralls didn't.

I lean to go with solution 2.

davidlatwe commented 4 years ago

Pinging @mottosso :telephone_receiver:

mottosso commented 4 years ago

Nice catch, solution 2 sounds good to me as well. At first I thought we were going to have to change the underlying Maya Docker images, that would have been a fair bit more involved. Phew! Will you take care of this @davidlatwe?

davidlatwe commented 4 years ago

Done !

davidlatwe commented 4 years ago

Someone has reporting this :point_right: https://github.com/z4r/python-coveralls/issues/73