Add config for Black or disable the 'Black check' for Hound CI

[jasperges]

It seems Hound CI recently (see for example this question by @BigRoy) started to check the code with Black. The only output you get from the Hound is "Black would make changes." So it seems it runs black --check on your code.

If this check is wanted, I would suggest to add a config for Black in the repository, unless the default options are totally fine. To add specific config parameters a pyproject.toml file has to be added with configuration options for Black. As @davidlatwe mentioned here the default values seem to conflict with PEP8. That is something that could probably be fixed in the config.

How do people feel about this?

[davidlatwe]

Add an example for what's conflicting with PEP8 in my IDE (was using SublimeText + sublack):

# original code
name = knob.name()[len(TEMP):]
# Everything's fine

# black formatted
name = knob.name()[len(TEMP) :]
# And my linter highlighted this line and says: "PEP 8 (E203): whitespace before ':' "

[davidlatwe]

I don't like Black. :angry:

[jasperges]

# black formatted
name = knob.name()[len(TEMP) :]

That is really stupid.

I also just noticed that the default line length is 88 (???). As discussed here it will be 80 for Avalon (strictly following PEP8).

It also wants me to change ' to ". I really don't like that to be forced...

[tokejepsen]

Voting for disabling Black.

[jasperges]

Just noticed this:

It is not configurable.

It does have support for YAPF block comments, but it is really ugly to litter your code with them.

I strongly vote for disabling Black.

[davidlatwe]

Just found this comment about whitespace before ":" :point_right: here

So... the one that is wrong, was my linter which using Flake8...

But even Black is correct on PEP 8, changing the style just to be on the right style side seems unnecessary. :/

Voting for stick with PEP8 + Flake8, disabling Black. :+1:

[BigRoy]

👍 - Let's put our new Hound to sleep and revive old black-less Hound. 🐩