getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
218 stars 49 forks source link

Style tweak, dimming highlight color #528

Closed davidlatwe closed 4 years ago

davidlatwe commented 4 years ago

What's changed

Before

9986041b-fa52-44ba-bc62-fd64defeee5d

After

3c8e4214-919b-47ea-bfff-9fa2a790d7bf

Custom header section text color

image

Motivation

Although I did think about overriding styles from the config, but then I thought it could become a bit harder to develop GUI in style that everyone could adopt since what other sees would be different from mine. So I decide to push the change I need and have a open discuss to see if everyone feels okay with it.

It's not much but I think it could improve the overall color contrast for seeing icons and other things that are a bit more important than selections. Bright icon friendly style. ☺️

mottosso commented 4 years ago

Nice one :)

BigRoy commented 4 years ago

Looking good! At first it did give me the feeling that somehow it was "disabled" because of the dimmed color but likely it just needs some getting used to.

What does it look like when a row is disabled? Or the widget is disabled?

I always wondered whether we should make the Alternating Row color slightly subtler and easier to the eye? Any thoughts on that?

davidlatwe commented 4 years ago

What does it look like when a row is disabled? Or the widget is disabled?

Good question, here's my test, disabling row and widget πŸ‘‡

8612a1e2-4827-48bd-a130-5bdc90e46897

It seems disabling widgets doesn't affect the highlight color, and the same result before this PR.

I always wondered whether we should make the Alternating Row color slightly subtler and easier to the eye?

I have thought about that, too. And I vote yes on that. πŸ‘

davidlatwe commented 4 years ago

A quick test on dimming alternative row color (alternate-background-color)

image

From #3A3939 to #2D2C2C.

mkolar commented 4 years ago

I like it. also with the dimming of the alternating colours. It's a bit softer which is always nice.

davidlatwe commented 4 years ago

Can we merge this ? πŸ˜ƒ