search

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
213 stars 48 forks source link

Fix #534 by implementing name validating widget #543

Open davidlatwe opened 4 years ago

davidlatwe commented 4 years ago

What's changed?

This fixes #534, not only invalid character will be blocked in GUI, invalid input from pasting will be cleaned for better UX.

But since Creator App also shares the same widget, it has changed, too.

69d82bae-f008-4036-804f-a1c3a407f39e

BigRoy commented 4 years ago

@davidlatwe That's great work! :) Lovely. 🚀 Also code looks clean.

I wonder however if it should include the reported message (the invalid characters) somewhere on the Widget too so the user is aware of that aside of the "red fade" on the QLineEdit. What do you think? Or would it be overkill?

davidlatwe commented 4 years ago

Thanks @BigRoy :D

Yeah, I agree that it would be better if we put a message printer in the bottom of that dialog. Furthermore, should we also check the asset name exists or not ? Like the Creator App did.