search

getavalon / core

The safe post-production pipeline - https://getavalon.github.io/2.0
MIT License
213 stars 48 forks source link

Asset switcher efficiency enhancement #551

Open iLLiCiTiT opened 4 years ago

iLLiCiTiT commented 4 years ago

Problem

Current asset switcher dialog is querying all documents in very inefficient way. The same document may be queried many times in separate database calls which makes asset switcher GUI really slow.

Suggested solution

Query documents of one type only once per each refresh step. So all representations are queried in one call, their versions, subsets and assets are queried in separate calls which means, to get parenthood of all representations needs a maximum of 4 calls to DB. We also validate each step of refresh, to prevent querying data which will not be used. This is not perfect change, it can be done even faster (and more complicated), but the performance improvement over current implementation is significant.

We tested on a feature film with around 400 assets. The speed difference to open the switcher GUI is: 10s with current code, 1-2s with the new code.

BigRoy commented 3 years ago

I believe @jasperges recently tested this feature and it "worked fine" for his needs. I believe @iLLiCiTiT at pype has also updated a variant of this code change.

Should we get this merged?

iLLiCiTiT commented 3 years ago

I believe @jasperges recently tested this feature and it "worked fine" for his needs.

@tokejepsen found a bug. https://github.com/pypeclub/pype/issues/423