search

getavalon / docker

Avalon in a Dockerfile
MIT License
5 stars 2 forks source link

Tests #17

Closed tokejepsen closed 6 years ago

tokejepsen commented 6 years ago

Goal

Implement #16

Implementation

Currently you need to install the pymongo module with pip to run the tests, because testing happens through Linux with the Docker Toolbox terminal.

mottosso commented 6 years ago

Thanks, could we stick with nose for tests? It's what it's used in core and Pyblish too (not sure what CGWire/gazu is using).

tokejepsen commented 6 years ago

Sure, we could do that. I'm not familiar with nose, but will have a look at the other repositories.

mottosso commented 6 years ago

It looks like the existing test can look the same, since it doesn't use anything pytest specific. Just replace pytest.main with nose.main.

tokejepsen commented 6 years ago

This is ready for a merge, unless we want Travis in on this as well?

mottosso commented 6 years ago

Travis would be good.

tokejepsen commented 6 years ago

Could you enable Travis for this repository?

mottosso commented 6 years ago

Ok, it's on!

tokejepsen commented 6 years ago

Are you able to look at the failed CI?

Dont know Travis well enough to know where to go with the error logs.

mottosso commented 6 years ago

Looks like it's the --import command that fails. Could also be docker being unable to bind to those ports.

tokejepsen commented 6 years ago

Is it supposed to display the help information for the docker command?

mottosso commented 6 years ago

No, it looks like the command is mistyped.

mottosso commented 6 years ago

PyQt5 for running the tests? If it's a dependency, it's probably just an unnecessary import someplace.

tokejepsen commented 6 years ago

PyQt5 for running the tests? If it's a dependency, it's probably just an unnecessary import someplace.

Its being checked for here. Think we spoke about maybe including PyQt5 for Linux as well.

mottosso commented 6 years ago

Think we spoke about maybe including PyQt5 for Linux as well.

Yeah, we did and we should, just wasn't sure you wanted to do bundling in the same PR as tests. I think bundling may need some work; for example, we may need to compile things ourselves to avoid dependencies of a given distribution, like CentOS or Ubuntu etc.

tokejepsen commented 6 years ago

Yeah, we did and we should, just wasn't sure you wanted to do bundling in the same PR as tests.

Yeah, I did give it a quick try, but gave up so just installing PyQt5 with pip and Travis instead.

mottosso commented 6 years ago

Starting avalon-launcher

Looks like it isn't seeing the arguments to avalon, and are running it without, which would boot up the Launcher, which requires a screen. We could add the Xvfb fake screen to the tests, but really, we shouldn't require PyQt for these tests. Should we just remove the check when not running the launcher?

tokejepsen commented 6 years ago

Looks like it isn't seeing the arguments to avalon

Yeah, I dont really get why that would be. Only thing I could imagine is something to do with the execution mode perhaps.

Should we just remove the check when not running the launcher?

Yeah, I think that might be the best option.

tokejepsen commented 6 years ago

I dont know how to proceed with this. I'm not developing on Linux, so it makes it very tricky for me to troubleshoot issues on Travis.

I would suggest instead that we setup CI on Appveyor, where I'm more familar and the testing can happen there for the time being, until someone working on Linux can step in a fix the Travis issues.

tokejepsen commented 6 years ago

Closing this and opening a new with multi container support.