Various fixes - Githubissues

tokejepsen commented 5 years ago

This started off as a single fix to support Docker for Desktop on Windows that now support pinging the container, similar to Docker Toolbox.

Continued using this fork and spotted various bugs I fixed. The commits should be fairly explanatory.

mottosso commented 4 years ago

Woah, a years worth of work. Could you help me summarise what's changed? :)

tokejepsen commented 4 years ago

Sorry, yeah :)

Removed hardcoded IP address to Docker Toolbox: 192.168.99.100. (https://github.com/getavalon/docker/pull/57/commits/17bf05221cc42cebd4daff32716587f152e3dafc)
Various update to the CGWire sync (will be redundant with CGWire integration with Avalon-core).
No argument to avalon --backup is needed, as it creates the file in the current working directory (https://github.com/getavalon/docker/pull/57/commits/7ecb899135157bac22dbb8d94a6bd1167a4d9c56)
Add Maya 2019 support (https://github.com/getavalon/docker/pull/57/commits/d2a9fafa5d5755b6355f8a43f000834abff7b830)
Add Nuke 11.0v4 support (https://github.com/getavalon/docker/pull/57/commits/fe3c1ea2b323b6b7ea9ce236981d062368312e64)
Environment variables like PATH and PYTHONPATH were not consistently inherited by child processes (https://github.com/getavalon/docker/pull/57/commits/862f6bf3fe09f806f319988a825ee052e5f906ff).
Improve copy/paste for docker commands (https://github.com/getavalon/docker/pull/57/commits/ef6454c23a5bd5a5cd4d7848e8518f82e7b0a444).
Nuke was not being setup correctly on launch with NUKE_PATH (https://github.com/getavalon/docker/pull/57/commits/5172c742fb131fa508f21687e653b2c0c2100184).

tokejepsen commented 4 years ago

Cool, thanks for having a look.

getavalon / docker