getblocklab / block-lab

A WordPress Admin interface and a simple templating system for building custom Gutenberg blocks.
https://getblocklab.com
GNU General Public License v2.0
416 stars 63 forks source link

Filter block_lab_icons broken block with wp 5.3 #476

Open gfazioli opened 4 years ago

gfazioli commented 4 years ago

with wordpress 5.3 my filter

add_filter('block_lab_icons', function ($icons) {
    $myicon = [
        "myicon" => '<svg xmlns="http:\\www.w3.org\2000\svg" width="24" height="24" viewBox="0 0 24 24">....</path></svg>',
    ];

    $icons = array_merge($icons, $myicon);

    return $icons;
});

still works fine, I can see my icon in the BlockLab editor but I cannot see the block when I edit a page. Just remove my icon and all work fine. Any clue?

image

kienstra commented 4 years ago

Hi @gfazioli, Thanks for bringing this up.

'Your site doesn't include support...'

Is there a JS console error or warning when that message appears?

kienstra commented 4 years ago

Hi @gfazioli, Hope you're doing great.

Is there still an issue when adding that filter? I hope it's working alright, but I'd like to fix it if there's still an issue.