getblocklab / block-lab

A WordPress Admin interface and a simple templating system for building custom Gutenberg blocks.
https://getblocklab.com
GNU General Public License v2.0
417 stars 63 forks source link

QA: URL Field Validation #510

Open JulieKuehl opened 4 years ago

JulieKuehl commented 4 years ago

Feature description

It would be good to validate that the default for a URL field contains a URL.

Screenshot (optional)

Screen Shot 2020-01-28 at 8 10 04 PM

Use case

Human error

Additional information

JulieKuehl commented 4 years ago

Oh look! It already does that when you try to save the block. Never mind.

kienstra commented 4 years ago

All good, thanks for the great report and screenshot.

JulieKuehl commented 4 years ago

Actually, there's an argument for UX that that error should appear before saving the block. It was kind of hidden as to why the block wouldn't save. I had to open all the fields to look for the error. That would hold for all the fields that are validated.