search

getbouncer / cardscan-ios

A library for scanning credit and debit cards
MIT License
207 stars 66 forks source link

Release 1.0.5024 breaks Carthage #112

Closed Sidetalker closed 4 years ago

Sidetalker commented 4 years ago

Release 1.0.5024 breaks Carthage compatibility.

Carthage error message: Dependency "cardscan-ios" has no shared framework schemes for any of the platforms: iOS

I may have time to look at this myself, just wanted to file an issue asap - for the time being I'm using 1.0.5023.

jaimejiyepark commented 4 years ago

Hello! Have you tried re-clicking shared in your project schemes in your workspace then building?

kingst commented 4 years ago

@Sidetalker I'm going to close this, please let us know if you are still having issues.

cmvagner commented 4 years ago

I'm having the same issue. Release 1.0.5023 does work with Carthage.

cmvagner commented 4 years ago

In version 1.0.5024 "Example/Pods/Pods.xcodeproj/xcshareddata/xcschemes/CardScan.xcscheme" was removed. I can't find any other shared scheme checked into the repo which Carthage can use.

jaimejiyepark commented 4 years ago

We're sorry about that! Our carthage build does seem to break in this version. If you don't mind, we have a more updated version available for you to use: version 1.0.5028.

cmvagner commented 4 years ago

I'm still getting Dependency "cardscan-ios" has no shared framework schemes for any of the platforms: iOS for version 1.0.5028.

jaimejiyepark commented 4 years ago

Hello @cmvagner and @Sidetalker! There was a mistake on our part with our gitignore where we didn't add in the shared xcscheme. If you guys don't mind trying out the newest version of CardScan available in our master repo where I added a patch.

Thank you guys again for bringing this up!

cmvagner commented 4 years ago

Hello @jaimejiyepark Just tried building with Carthage using latest commit 613afb948185d211fdee1cf3a6103cb841df11c0 and now it works. Thank you!