Orientation fix - Githubissues

getbouncer / cardscan-ios

A library for scanning credit and debit cards

MIT License

207 stars 66 forks source link

Orientation fix #143

Closed jaimejiyepark closed 4 years ago

jaimejiyepark commented 4 years ago

Changes:

Aligning PreviewView's and VideoFeed's orientation to interface orientation
Added NavViewController to simulate Groupon bug

Note:

Since PreviewView and the images are two independent outputs, we have to align both orientations. Originally fixed just PreviewView and it looked correct but images came out misaligned.

Questions:

On a sep branch, I did the 16:9 cropping but the card in the full screen image takes up too much of the width for it properly crop 16:9. It cuts out a lot of the image. Please ask me for the images on Slack.