search

getbouncer / cardscan-ios

A library for scanning credit and debit cards
MIT License
207 stars 66 forks source link

Resume threads if deallocated when in background #157

Closed kingst closed 4 years ago

kingst commented 4 years ago

I wasn't able to trigger this bug myself, but I did see a report from Crashlytics on the user study and I'm 90% sure that this fixes it.

jaimejiyepark commented 4 years ago

shouldnt the mlqueue resuming and suspension be in the mutexqueue as well to ensure they behave properly before it backgrounds or not?

kingst commented 4 years ago

The sync call on the machine learning queues make sure that the ML is done before the thread is suspended

jaimejiyepark commented 4 years ago

but the for loop isnt in the mutex queue. shouldnt it be in the mutex queue?

jaimejiyepark commented 4 years ago

shipit