Update system tests to run on simulator and in github workflow

getbouncer / cardscan-ios

A library for scanning credit and debit cards

MIT License

207 stars 66 forks source link

Update system tests to run on simulator and in github workflow #249

Closed kingst closed 3 years ago

kingst commented 3 years ago

I couldn't find a way to do that. This loop is protected with both a testDataSource and isSimulator check so it should be safe, but please do double check that because I agree with your concern

jaimejiyepark commented 3 years ago

Tested the system tests out with the simulator and they work. Just to be safe, should we add the internal attribute to those functions since they should only be used internally?

jaimejiyepark commented 3 years ago

i'll test it once more with the changes