search

getbouncer / cardscan-ios

A library for scanning credit and debit cards
MIT License
207 stars 66 forks source link

Fatal Error when run configure in AppDelegate #49

Closed otnielyehezkiel closed 5 years ago

otnielyehezkiel commented 5 years ago

Device Iphone 6+ OS Version 12.4 XCode Version 10.3

Fatal error: Unexpectedly found nil while unwrapping an Optional value image

thanks before 🙇

kingst commented 5 years ago

We dropped support for the iPhone 6 and 6 plus recently. Would it be useful to add an option to still support these older devices?

kingst commented 5 years ago

Also, we have an isCompatible static method on the ScanViewController class which you should use proactively to check if a device will work with CardScan.

otnielyehezkiel commented 5 years ago

Would it be useful to add an option to still support these older devices

There are +- 20 percentage user using Iphone 6 and Iphone6+ in our apps. I think i must consider using another 3rd party. Anw, thanks for information @kingst 👍

kingst commented 5 years ago

This change was fairly recent for us, so it's good to hear this feedback. Before you switch to another library try version 1.0.5002, which is the last one with iPhone6 / 6+ support. I'd love to get your feedback on it!

otnielyehezkiel commented 5 years ago

oke sure, will try 1.0.5002 version first.

preetamjadakar commented 5 years ago

@kingst : May I know whats the major difference between current version and earlier 1.0.5002 ? Why the support for iPhone6 was dropped? Any major benefits we achieved by dropping support for older devices?

kingst commented 5 years ago

The only difference is that we dropped iPhone 6 support. We did this to make integration easier for one of our customers who sees less than 3% of their traffic from iPhone 6 and older. The major benefit is that the GPUs on older devices don't work as well for our machine learning models as the newer GPUs do.

Sounds like there is some interest in continuing to support older iPhones. Try out version 1.0.5002 and let me know if the performance is acceptable for your use case. If so, I'll add a flag that lets you enable older iPhones, then you can upgrade to the latest version.

kingst commented 5 years ago

Hi @otnielyehezkiel and @preetamjadakar any updates, did it work well for your users?

FYI: We have a new model architecture coming out in the next few months that will add iPhone 6 back, but these things are hard so it will take some time.

preetamjadakar commented 5 years ago

Hey @kingst , sorry for the delayed response. I was working on one POC and everything went excellent. Thank you some much.

Please update us on next major release, will be glad to go through and check it out.

kingst commented 5 years ago

Great, thanks for the update. I'm going to default to having older devices off, but here is a PR that will be in our next release that lets you enable it:

https://github.com/getbouncer/cardscan-ios/pull/69

We'll do a release this week, so I'm going to close this issue.

kingst commented 5 years ago

Hi All, just to update this thread that PR hit production today with Pod version 1.0.5009