getbrevo / brevo-php

A fully-featured PHP API client to interact with Brevo.
https://developers.brevo.com/
MIT License
51 stars 23 forks source link

Php 8 GuzzleHttp\Psr7\Stream::getContents stream is not getting the response content #1

Open massimoconti opened 1 year ago

massimoconti commented 1 year ago

As stated in the title running the library with php 8.1 trigger an unexpected behavior with \GuzzleHttp\Psr7\Stream::getContents. For instance in ContactApi::requestContactExportWithHttpInfo this code:

if ($returnType === '\SplFileObject') {
    $content = $responseBody; //stream goes to serializer
} else {
    **$content = $responseBody->getContents();**
    if ($returnType !== 'string') {
        $content = json_decode($content);
    }
}

return a $content = "".

I didn't go into details, but I found that might be a stream issue. If I cast $responseBody into a string it works as expected since $content turn to be something like {"processId":90} thank to magic method GuzzleHttp\Psr7\Stream::__toString.

$content = (string) $responseBody;

Maybe it's a guzzle http issue, not a brevo php sdk issue.

Thanks in advance

massimoconti commented 1 year ago

Http api call works well, since logging it return me the expected response:

[2023-06-20T15:12:34.679754+02:00] brevo.INFO: POST /v3/contacts/export { "customContactFilter": { "actionForContacts": "unsubscribed", "listId": 2 } } - Response: 202 {"processId":90} [] []

massimoconti commented 1 year ago

I found that the problem is connected with the logging operation. Since it consumes the stream messagge it is not available for reading it again, unless the client api force the rewind of the stream, which is accomplished for instance with the magic method __toString ($content = (string) $responseBody;) as stated above.

I guess it could be improved in swagger-codegen code generation.

massimoconti commented 1 year ago

Look like someone else already got into the same problem: https://github.com/swagger-api/swagger-codegen/issues/11651