search

getcanoe / canoe

Canoe is a Nano Wallet heavily based on the MIT licensed Copay wallet from Bitpay
https://getcanoe.io
MIT License
142 stars 28 forks source link

Something going wrong with some alternative currencies #114

Closed ceddup closed 6 years ago

ceddup commented 6 years ago

I'm big on currencies like the ones used in Venezuela and Myanmar. These people are struggling and would sure use Canoe. If one goes from dollard to MMR (Myanmar) from the alternative currency setting and then send Nanos : everything goes right, NANO is well converted to MMK.

But, after reloging (wallet) or even if you wait a minute (profileService.updateRate), then convertion is gone

This makes the app less usefull for people there It has something to do with how https://api.coinmarketcap.com behaves But it works, sometimes, pretty frustrating...

I can reproduce it but not fix it, so I guessed I would make a ticket

Of course not urging for beta

gokr commented 6 years ago

I am rewriting rateService for beta so lets revisit after that.

Den ons 14 feb 2018 01:27ceddup notifications@github.com skrev:

I'm big on currencies like the ones used in Venezuela and Myanmar. These people are struggling and would sure use Canoe. If one goes from dollard to MMR (Myanmar) from the alternative currency setting and then send Nanos : everything goes right, NANO is well converted to MMR.

But, after reloging (wallet) or even if you wait a minute (profileService.updateRate), then convertion is gone

This makes the app less usefull for poeple there It has something to do with how https://api.coinmarketcap.com behaves But it works, sometimes, pretty frustrating...

I can reproduce it but not fix it, so I guessed I would make a ticket

Of course not urging for beta

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/getcanoe/canoe/issues/114, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFaHkRxSW9j9_3GEZ4Z-qwjuewXVMN6ks5tUiiNgaJpZM4SEnls .

ceddup commented 6 years ago

I found the reason for this bug. rateService gets it's rates from https://bitpay.com/api/rates -> bitpay knows MMK rate, see https://bitpay.com/api/rates/MMK But profileService gets it's rate from coinmarketcap.com that doesn't know about MMK see, no 'price_mmk' entry : https://api.coinmarketcap.com/v1/ticker/raiblocks/?convert=MMK Whereas eur is fine, we get the 'price_eur' entry : https://api.coinmarketcap.com/v1/ticker/raiblocks/?convert=EUR

Anything wrong with using bitpay over coinmarketcap ?

schenkty commented 6 years ago

@ceddup it looks like bitpay rates are only for bitcoin. the MMK price looks to be an issue with coinmarketcap in general. May have to submit something to them to see if they can fix it

gokr commented 6 years ago

@ceddup Can you check if this one can be closed now?

ceddup commented 6 years ago

Ok, will do this evening

stefonarch commented 6 years ago

I think this is fixed, it happens with high deflationary currencies mmk

ceddup commented 6 years ago

We can close this ticket to me. The account balance convertion (≈ 5 EUR) doesn't display after onboarding, but that should be another ticket imho

stefonarch commented 6 years ago

Convertion does never show for 0 balance, so no issue here: schermata-01-07-52-12

ceddup commented 6 years ago

Can be closed I think (fixed 0 Nano convertion)