search

getcanoe / canoe

Canoe is a Nano Wallet heavily based on the MIT licensed Copay wallet from Bitpay
https://getcanoe.io
MIT License
142 stars 28 forks source link

Enhance Currency switch in send tab #253

Closed stefonarch closed 6 years ago

stefonarch commented 6 years ago

switch-amount Also round Nano amount to 2-4 digits.

Stormtv commented 6 years ago

Any details on what is the problem / how we can improve this?

Stormtv commented 6 years ago

Nvm you edited the issue after I posted that

Stormtv commented 6 years ago
screen shot 2018-04-11 at 11 19 50 pm

Added this here let me know what you think

stefonarch commented 6 years ago

Doesn't it show both currencies/conversion anymore? Ok maybe because of small amount here? Is the rounding for Nano done too? It looks ... not quite nice. schermata-12-08-03-35

stefonarch commented 6 years ago

Ok, compiled, works on localhost, but the max button is very tiny (css issue?)

gokr commented 6 years ago

Looks great, modulo comments above! The whole formatting of amounts needs an overhaul.

stefonarch commented 6 years ago

It works fine in appimage, but does not reset, not sure if it should. Let's say you have sent Euro, you will send by default Euro. Maybe grey out a little bit the lower amount? It could produce errors, when people don't double check screen messages.

Stormtv commented 6 years ago

Config stores your preferred send type and we have a lot of confirmations already I think it is fine to store it. Merged this to master and closing.