Hex on colours break when using html colours

getchopchop / chopchop

Front end user interface primer toolkit for the pro's

https://getchopchop.github.io

MIT License

31 stars 7 forks source link

Hex on colours break when using html colours #158

Closed daveredfern closed 7 years ago

daveredfern commented 7 years ago

When using a HTML colour such as green it breaks the hex colours on branding/color. Only works with hex colours. Something to do with not adding it to the array.

gazjoy commented 7 years ago

@daveredfern also breaks when using gradients.

gazjoy commented 7 years ago

@Triickii as discussed. We could do with 1 function that deals with all this.

At the moment the same code is output in 3 places.

pattern/branding/color/color.php pattern/utility/color/fill.php pattern/utility/color/text.php

daveredfern commented 7 years ago

A related issue is on this ticket: https://github.com/getchopchop/chopchop/issues/182