getchopchop / chopchop

Front end user interface primer toolkit for the pro's
https://getchopchop.github.io
MIT License
31 stars 7 forks source link

Should we rename Icons folder #91

Closed jakecobley closed 8 years ago

jakecobley commented 8 years ago

We're moving towards most of our images being SVG's, logo's etc, not just icons. Does 'icons' still fit?

daveredfern commented 8 years ago

@jakecobley I agree. maybe vector instead? What do you think @gazjoy ?

gazjoy commented 8 years ago

@daveredfern sure. Its just fluff.

daveredfern commented 8 years ago

@gazjoy @jakecobley we spoke about this and decided to leave it. Are we changing or not? :)

jakecobley commented 8 years ago

I think it would be nice to change it, something like 'vectors' that @daveredfern suggested is a better representation of what lives in the directory. But if anyone's against it it doesn't matter either. 'Icons' is still relevant.

daveredfern commented 8 years ago

@jakecobley don't think anyone is against it so go for it :)

jakecobley commented 8 years ago

PR #114

daveredfern commented 8 years ago

All done @jakecobley. Thanks!