Closed robvanderleek closed 7 months ago
Attention: Patch coverage is 92.67982%
with 115 lines
in your changes are missing coverage. Please review.
Project coverage is 94.40%. Comparing base (
6424204
) to head (a8a4b03
). Report is 4 commits behind head on main.:exclamation: Current head a8a4b03 differs from pull request most recent head 8bf23c9. Consider uploading reports for the commit 8bf23c9 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@robvanderleek since there is a license change with this PR, maybe it should be moved to a separate PR or cut a new release for it? Thanks!
relates to https://github.com/Homebrew/homebrew-core/pull/168759
Hi @chenrui333
Yes, I was planning to make a new release for the license change. I worked a lot on the code-analysis part the past weeks and decided the implementation deserves a more strict open-source license than ISC.
I wasn't aware my changes in main
would trigger Homebrew builds (BTW I'm impressed by the active and kind support from Homebrew maintainers).
Is it enough if I make a new release? Also, if I'm missing some kind of best practice where my development activities in main
should not immediately lead to Homebrew changes, let me know.
Hi @chenrui333 FYI I've released version 0.9.0: https://pypi.org/project/codelimit/0.9.0/
yeah, new release would be good, but I notice there is some license discrepancy issue in the README though. Besides GPL-3.0 is deprecated. I will drop a quick PR on this. Thanks!
The latest updates on your projects. Learn more about Vercel for Git ↗︎