getcodelimit / codelimit

Your Refactoring Alarm 🔔
https://codelimit.vercel.app
GNU General Public License v3.0
36 stars 3 forks source link

feat: ✨ Multi-language support #32

Closed robvanderleek closed 7 months ago

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codelimit-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 5:04pm
codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 92.67982% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 94.40%. Comparing base (6424204) to head (a8a4b03). Report is 4 commits behind head on main.

:exclamation: Current head a8a4b03 differs from pull request most recent head 8bf23c9. Consider uploading reports for the commit 8bf23c9 to get more accurate results

Files Patch % Lines
codelimit/common/utils.py 33.82% 45 Missing :warning:
codelimit/common/Scanner.py 76.74% 20 Missing :warning:
codelimit/common/gsm/utils.py 78.00% 11 Missing :warning:
codelimit/common/gsm/automata/State.py 64.00% 9 Missing :warning:
codelimit/common/ScanTotals.py 78.26% 5 Missing :warning:
...elimit/common/token_matching/predicate/Balanced.py 87.50% 4 Missing :warning:
codelimit/common/gsm/predicate/Predicate.py 76.92% 3 Missing :warning:
codelimit/common/ScanResultTable.py 92.30% 2 Missing :warning:
codelimit/common/gsm/matcher.py 97.82% 2 Missing :warning:
codelimit/common/scope/scope_utils.py 97.05% 2 Missing :warning:
... and 10 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32 +/- ## ========================================== - Coverage 94.88% 94.40% -0.48% ========================================== Files 59 88 +29 Lines 1974 2736 +762 ========================================== + Hits 1873 2583 +710 - Misses 101 153 +52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chenrui333 commented 7 months ago

@robvanderleek since there is a license change with this PR, maybe it should be moved to a separate PR or cut a new release for it? Thanks!

relates to https://github.com/Homebrew/homebrew-core/pull/168759

robvanderleek commented 7 months ago

Hi @chenrui333

Yes, I was planning to make a new release for the license change. I worked a lot on the code-analysis part the past weeks and decided the implementation deserves a more strict open-source license than ISC.

I wasn't aware my changes in main would trigger Homebrew builds (BTW I'm impressed by the active and kind support from Homebrew maintainers).

Is it enough if I make a new release? Also, if I'm missing some kind of best practice where my development activities in main should not immediately lead to Homebrew changes, let me know.

robvanderleek commented 7 months ago

Hi @chenrui333 FYI I've released version 0.9.0: https://pypi.org/project/codelimit/0.9.0/

chenrui333 commented 7 months ago

yeah, new release would be good, but I notice there is some license discrepancy issue in the README though. Besides GPL-3.0 is deprecated. I will drop a quick PR on this. Thanks!