search

getcodice / codice

Online note-taking and task-management application
http://codice.eu
MIT License
14 stars 3 forks source link

Switch to logging in with a login #4

Closed Sobak closed 8 years ago

Sobak commented 8 years ago

Email can be changed so it's not a best idea, I think

soanvig commented 8 years ago

Does login cannot be changed? E-mail is (for me) bullet-proof solution. After change one logins with different credientials. It's obvious like changing password. Just put a notice near e-mail editing. For future you can add a feature which saves all e-mails changes and display something like "This e-mail has been changed 3 months ago"

logarytm commented 8 years ago

My proposal:

$this->tryTo(looks_like_email($username) ? $this->loginWithEmail($username) : $this->loginWithUsername($username));
Sobak commented 8 years ago

@ewancarth this sounds cool, but on the other hand, doesn't it mean that we loose flexibility of username? As for now, it doesn't have limited range of characters and it doesn't need to be uniqe - you can have John Smith as your username, even if there are more than one - just displayed name which is, in fact, independent from the system.

Does login cannot be changed?

@soanvig: please note that usually it can't - most of web services I know doesn't allow for that as unique identifier is important to avoid confusion when users are interacting between each other.

However, there are no plans for interactions between users in same instance of Codice, so that's not a case here.

I think you all convinced me, I will probably just stay with an email and add a note that changing it also means changing login credentials.

Thank you for the feedback, I love feedback :D