getcursor / cursor

The AI Code Editor
https://cursor.com
20.63k stars 1.38k forks source link

Meslo NF Font Family support for p10k terminal setups #1366

Open michaelbship opened 3 months ago

michaelbship commented 3 months ago

Is your feature request related to a problem? Please describe. On VSCode, I can add "terminal.integrated.fontFamily": "MesloLGS NF", to the settings.json file and it will allow my p10k terminal theme to show GitHub icons and the rest. If I add that same line to Cursor's settings.json, nothing appears to change in the terminal, even if I reset cursor.

Describe the solution you'd like Make it so my p10k theme with Meslo NF font works in the Cursor terminal

Additional context Iterm2 and VSCode (post adding the font line in settings):

Screenshot 2024-03-28 at 21 55 28

Cursor terminal:

Screenshot 2024-03-28 at 21 55 11
seigtm commented 3 months ago

Doubt that it's related. I'm using p10k with MesloLGS NF in Cursor and it's working as expected.

image

michaelbship commented 3 months ago

@seigtm Any suggestions on things for me to try here? Clearly doesn't work for me when simply adding to the settings.json of cursor.

seigtm commented 3 months ago

Try this:

- "terminal.integrated.fontFamily": "MesloLGS NF"
+ "terminal.integrated.fontFamily": "'MesloLGS NF'" 
seigtm commented 3 months ago

It's unrelated to the Cursor app.

The same issue occurs in plain VS Code if you forget to wrap your font family argument with ' ' inside " ".

seigtm commented 3 months ago

@michaelbship