search

getdave / Tanlinell

Boilerplate Wordpress theme for rapid development of new WP themes. Based on the great work of the _s ("Underscore") theme.
GNU General Public License v2.0
6 stars 2 forks source link

Amend bug in rem mixin #173

Closed getdave closed 10 years ago

getdave commented 11 years ago

rem() mixin uses $baseFontSize but it actually has to work with the base size of the html element. We need to assume this is 16px.

Amend as per by adding 16 instead of $baseFontSize

      @if $unit == "px" {  /* 7 */
        $px : append($px,  $value);
        $rem: append($rem, ($val / 16 + rem));
      }

      @if $unit == "rem" { /* 7 */
        $px : append($px,  ($val * 16 + px));
        $rem: append($rem, $value);
      }
getdave commented 10 years ago

Fixed via another commit. Closing