search

getdave / grunt-deployments

MYSQL database deployments using GruntJS
MIT License
72 stars 34 forks source link

Added support for custom SSH ports #25

Closed jdsimcoe closed 10 years ago

jdsimcoe commented 10 years ago

I also updated the README file to reflect this new field I added. I also made sure to incorporate your latest changes.

getdave commented 10 years ago

I appreciate this pull request. I promise to review it asap.

jdsimcoe commented 10 years ago

Cool.

_I am one of _thesimcoes.net→ http://thesimcoes.net/

dtr.mn→ http://dtr.mn/_with me to know Jesus_

On Fri, Nov 22, 2013 at 3:36 AM, Dave Smith notifications@github.comwrote:

I appreciate this pull request. I promise to review it asap.

— Reply to this email directly or view it on GitHubhttps://github.com/getdave/grunt-deployments/pull/25#issuecomment-29066473 .

getdave commented 10 years ago

@jsimcoe Could you possibly amend the commit to go into "develop" branch please? Much appreciated.

getdave commented 10 years ago

@jsimcoe Any chance you could amend the commit destination as above? Much appreciated.

Also if you could close the pull request(s) that is/are no longer valid I'd really appreciate it.

jdsimcoe commented 10 years ago

Done. I tested it on one of my projects and it works like a champ.

_I am one of _thesimcoes.net→ http://thesimcoes.net/

dtr.mn→ http://dtr.mn/_with me to know Jesus_

On Thu, Jan 2, 2014 at 3:10 AM, Dave Smith notifications@github.com wrote:

@jsimcoe https://github.com/jsimcoe Any chance you could amend the commit destination as above? Much appreciated

— Reply to this email directly or view it on GitHubhttps://github.com/getdave/grunt-deployments/pull/25#issuecomment-31446959 .

jdsimcoe commented 10 years ago

I also just made it so they if someone leaves the ssh_port off it will default to the SSH standard port of 22. I also updated the README accordingly. Let me know if anything looks out of place.

getdave commented 10 years ago

Closing in favour of commits into the develop branch