search

getditto / DittoAndroidTools

Diagnostic and Debugging Tools for Ditto Android SDK
MIT License
6 stars 1 forks source link

Prepare presence viewer, disk usage and export logs for deployment #28

Closed texasRanger09 closed 10 months ago

texasRanger09 commented 10 months ago

@phatblat If we had already published a version of the tools without the ArtifactId, then do we just need to push an update to them? I.e this won’t create a new maven repo for each library now that it has an artifactId, right?

anyercastillo commented 10 months ago

I can see the following three options for package name:

No matter which one we choose, the @phatblat suggestion of define the artifactId is very important to prevent undesired packages name as a result of a module rename.

phatblat commented 10 months ago

@phatblat If we had already published a version of the tools without the ArtifactId, then do we just need to push an update to them? I.e this won’t create a new maven repo for each library now that it has an artifactId, right?

Without specifying the artifactId value, a name will be used automatically - typically the gradle project name. This is fragile because without rootProject.name set in settings.gradle(.kts), the name will be the current directory name.

As for the versions previously published, they look broken to me. The https://s01.oss.sonatype.org/content/groups/public/live/ditto/ folder lists all maven "artifacts" published for the live.ditto group ID. Note that ditto, ditto-cpp and dnssd all contain a maven-metadata.xml file and folders for each version. The artifacts you've published contain only a subfolder, so I don't know if tools like gradle and maven will find these things that they need to find the actual artifacts.

These might work if they are referenced with maven coordinates of live.ditto:dittodatabrowser.DittoDataBrowser:0.0.1, which is very redundant containing 3 references to "ditto".

phatblat commented 10 months ago
  • live.ditto.dittopresenceviewer:DittoPresenceViewer:0.0.1 [used by this PR]
  • live.ditto:dittopresenceviewer:0.0.1 [suggested by @phatblat]
  • live.ditto.tools:dittopresenceviewer:0.0.1

I'd actually like to see maven coordinates of live.ditto:presenceviewer:0.0.1. Or, if we really want to keep a "ditto" reference in the artifactId, in addition to the one in the groupId, adding a dash helps with readability: live.ditto:ditto-presenceviewer:0.0.1

texasRanger09 commented 10 months ago

@anyercastillo @phatblat I added the artifactID to each library and pushed an update of the libraries to Maven

phatblat commented 10 months ago

The 0.0.2 versions look better. There is a 0.0.2 version folder under https://s01.oss.sonatype.org/content/groups/public/live/ditto/dittodatabrowser/ and the maven-metadata.yml file shows up in the right place.

texasRanger09 commented 10 months ago

I have updated all of the libraries and the readME to include the changes. If I could get another review cc/ @phatblat, @anyercastillo