search

getditto / DittoAndroidTools

Diagnostic and Debugging Tools for Ditto Android SDK
MIT License
6 stars 1 forks source link

Remove heartbeat collection subscription #84

Closed bplattenburg closed 3 months ago

bplattenburg commented 4 months ago

Today, we automatically subscribe any device using the hearbeat tool to the entire dittotools_devices collection, but that doesn't scale to production across multiple locations.

Instead, we want to make this "opt-in" by creating manual subscriptions do devices at the same location if desired, and remove the subscription from the tool itself

okdistribute commented 4 months ago

Should we even create any subscriptions as part of this tool at all? Seems a bit like magic that should be user controlled. Side effects need to be avoided to reduce unintended consequences.

The heartbeat tool could be a simple way to get data out on an interval. It doesn't need to subscribe to anything to function.

bplattenburg commented 4 months ago

@okdistribute It's definitely worth some more discussions. The original intent was to allow multi-hop to get the data out for devices that couldn't directly connect to the Big Peer, but that requires some level of scoping to subscribe only to devices at the same physical location.