Closed rdas-ditto closed 2 months ago
Looks really clean!
Do we lose the Change Identity
UI here? That's not part of the AllToolsMenu
tool because its only used in the test app, tool usage in a customer app would have an existing Ditto Identity.
Thanks!
The Change Identity UI has just been moved to a toolbar item (a gear icon in the top right corner), which in fact toggles .isShowingLoginSheet
in the viewModel instead of using a navigation item.
That implementation still resides in the App portion, rather than the framework, as it remains up to Customers to implement their own identity management.
That will teach me not to skim the description and screenshots instead of diving deeper into the code.
Thanks for taking the extra time to ensure this works well on iPhone, iPad, and tvOS!
Pulled changes from Main, and verified it runs on Mac too.
I was holding out to check if my changes were working on Apple TV hardware, but discovered the issue I was seeing is present on main
, so I'm going to go ahead and close/merge this and I've opened an issue.
Overview:
This PR simplifies the app's initial screen, and improves view encapsulation and readability.
Key Changes:
Ditto Tools App: Removed Redundant Initial Screen:
AllToolsMenu
directly on the initial screen.@State
variables and added a sidebar menu for iPad.Improved Encapsulation:
ExportButton
.Impact:
Testing:
Screenshots:
iOS:
iPadOS:
tvOS: