Remove extern crates from napi-dispatcher

getditto / safer_ffi

Write safer FFI code in Rust without polluting it with unsafe code

http://getditto.github.io/safer_ffi

MIT License

925 stars 40 forks source link

Remove extern crates from napi-dispatcher #142

Closed maddiemort closed 1 year ago

maddiemort commented 2 years ago

Denying rust_2018_idioms flags the extern crate napi; as unused - and if I'm understanding Rust 2018 correctly, both of these can be removed because the pub extern crate can be turned into a re-export.

Am I off-base here? I don't think this should break anything.

danielhenrymantilla commented 1 year ago

Yeah, I'm tempted to say it should be fine, but since Cargo can get confused with renames (it's an are where it's incredibly brittle / not up to the standards of a mature feature), I'll have to try it against a codebase extensively using the js features, such as ditto 🤞

danielhenrymantilla commented 1 year ago

Fixed in https://github.com/getditto/safer_ffi/pull/155 🙂