getdnsapi / getdns

A modern asynchronous DNS API https://getdnsapi.net/
Other
468 stars 126 forks source link

Build fails on a Raspberry Pi with ‘TLS1_3_VERSION’ undeclared #411

Closed tobiasisenberg closed 5 years ago

tobiasisenberg commented 5 years ago

Commit https://github.com/getdnsapi/getdns/commit/1904ee73181b8d176061c94584709470915f5d7c#diff-699d79a445d2eef1634876ba242884f7 broke the build, with the following error:

[12:09:05] openhabian@openHABianPi:~/getdns/build$ make
cd src && make default
make[1]: Entering directory '/home/openhabian/getdns/build/src'
../libtool --quiet --tag=CC --mode=compile gcc -I../../src -I. -I../../src/util/auxiliary -I../../src/../stubby/src -g -O2 -Wall -Wextra -D_BSD_SOURCE -D_DEFAULT_SOURCE   -Wpedantic -c ../../src/const-info.c -o const-info.lo
../libtool --quiet --tag=CC --mode=compile gcc -I../../src -I. -I../../src/util/auxiliary -I../../src/../stubby/src -g -O2 -Wall -Wextra -D_BSD_SOURCE -D_DEFAULT_SOURCE   -Wpedantic -c ../../src/convert.c -o convert.lo
In file included from ../../src/convert.c:50:0:
../../src/util-internal.h: In function ‘_getdns_tls_version2openssl_version’:
../../src/util-internal.h:229:29: error: ‘TLS1_3_VERSION’ undeclared (first use in this function)
  case GETDNS_TLS1_3: return TLS1_3_VERSION;
                             ^~~~~~~~~~~~~~
../../src/util-internal.h:229:29: note: each undeclared identifier is reported only once for each function it appears in
Makefile:122: recipe for target 'convert.lo' failed
make[1]: *** [convert.lo] Error 1
make[1]: Leaving directory '/home/openhabian/getdns/build/src'
Makefile:53: recipe for target 'default' failed
make: *** [default] Error 2

Going back to https://github.com/getdnsapi/getdns/commit/6a5e96d4e1d09ef535ecc0bf767dc2bb20278d02 fixed the issue for me.

wtoorop commented 5 years ago

No worries, I noticed this as well and have mitigation in place on the release/v1.5.0 branch