search

getdnsapi / getdns

A modern asynchronous DNS API https://getdnsapi.net/
Other
461 stars 127 forks source link

GetDNS 1.7.0 cannot find libidn2 2.3.3 but can find libidn2 2.3.2 - fixed version of cmake recipe in pull request #521

Closed jpbion closed 2 years ago

jpbion commented 2 years ago

In LibIDN2 v2.3.3, the definition line of the LibIDN2 version contains extra whitespace which causes the fragile version-number checking recipe for CMake to fail. Included as a comment is a patch that makes it a bit more robust, so version 2.3.3 works with GetDNS.

I created a pull request with the needed change to cmake/modules/FindLibidn2.cmake

saradickinson commented 2 years ago

Fixed by https://github.com/getdnsapi/getdns/pull/522 - thanks!