fix build issue

[chenrui333]

fix build error as below:

/tmp/getdns-20220820-35872-b98qtd/getdns-1.7.2/src/gldns/parse.c:250:16: error: implicitly declaring library function 'free' with type 'void (void *)' [-Werror,-Wimplicit-function-declaration]
               free(fkeyword);
               ^

relates to Homebrew/homebrew-core#108544

[wtoorop]

Thanks @chenrui333 , but these files are synced with https://github.com/NLnetLabs/unbound/tree/master/sldns

I think commit 9c076ca solves it without changing the files in the gldns directory. Can you confirm that's the case?

[chenrui333]

Thanks @chenrui333 , but these files are synced with https://github.com/NLnetLabs/unbound/tree/master/sldns

I think commit 9c076ca solves it without changing the files in the gldns directory. Can you confirm that's the case?

yeah, let me give that a try.

[l2dy]

Did you raise the issue to Unbound? If upstream fixes it, we may not need this workaround.

[wtoorop]

Did you raise the issue to Unbound? If upstream fixes it, we may not need this workaround.

I don't consider it a workaround to be honest. We just had to provide to through our cmake files what unbound provide via its autoconf. Thanks for the heads up though!

[l2dy]

Got it. Your commit did fix the issue and this pull request can be closed.

[chenrui333]

Sorry about the late reply, locally builds out fine, but still fail in the CI. 🤔