search

getdnsapi / getdns

A modern asynchronous DNS API https://getdnsapi.net/
Other
461 stars 127 forks source link

Fix Windows build #538

Open AstralStorm opened 1 year ago

AstralStorm commented 1 year ago

Fixes #537. Stubby will need an update once its service fix PR is merged.

saradickinson commented 1 year ago

@wtoorop I've merged the related Stubby PR and updated the submodule. With the fixes in this PR everything builds on Windows again, so this can be merged if you are happy with it.

wtoorop commented 1 year ago

@wtoorop I've merged the related Stubby PR and updated the submodule. With the fixes in this PR everything builds on Windows again, so this can be merged if you are happy with it.

Yes, will do, I just have to make sure the changes to gldns are also in upstream Unbound's sldns so they won't be reversed in the future again when syncing up with Unbound.

BillyONeal commented 11 months ago

We see this build failure in the update submitted by @jiayuehua . See https://github.com/microsoft/vcpkg/pull/34188

(As an aside it would be nice to have a variable we can turn off to disable generating docs instead of patching but that's unrelated)

BillyONeal commented 11 months ago

I note that their patch also guards for HAVE_TIME_H

MonicaLiu0311 commented 9 months ago

Any progress here?