getdnsapi / stubby

Stubby is the name given to a mode of using getdns which enables it to act as a local DNS Privacy stub resolver (using DNS-over-TLS).
https://dnsprivacy.org/dns_privacy_daemon_-_stubby/
BSD 3-Clause "New" or "Revised" License
1.18k stars 99 forks source link

Issue with CMake build during install #239

Closed ArchangeGabriel closed 4 years ago

ArchangeGabriel commented 4 years ago

I’m building this way after extracting the tarball:

cmake -B build stubby-0.3.0
make -C build
make -C build DESTDIR="${pkgdir}" install

This results in:

CMake Error at cmake_install.cmake:88 (file):
  file COPY cannot copy file "/build/stubby/src/build/stubby.yml" to
  "/etc/stubby/stubby.yml": No such file or directory.

Seems it is not accounting for DESTDIR. I’ve tried to look at the corresponding code, but it’s too complex for me to read.

ArchangeGabriel commented 4 years ago

Relevant part: https://github.com/getdnsapi/stubby/blob/develop/CMakeLists.txt#L124

ArchangeGabriel commented 4 years ago

https://github.com/getdnsapi/stubby/commit/2fec82b1669bb35062ff9029c4b42fb4998fbd44 https://github.com/getdnsapi/stubby/commit/c4841747a8042dfe2ea43c3c58d07a87e5a5a0ed