[PATCH] tls_ca_file conf broken in 0.4.0

getdnsapi / stubby

Stubby is the name given to a mode of using getdns which enables it to act as a local DNS Privacy stub resolver (using DNS-over-TLS).

https://dnsprivacy.org/dns_privacy_daemon_-_stubby/

BSD 3-Clause "New" or "Revised" License

1.2k stars 99 forks source link

[PATCH] tls_ca_file conf broken in 0.4.0 #296

Closed john9527 closed 3 years ago

john9527 commented 3 years ago

Similar to #290, tls_ca_file is also broken with the new config quote check. Patch

--- a/getdns/stubby/src/yaml/convert_yaml_to_json.c
+++ b/getdns/stubby/src/yaml/convert_yaml_to_json.c
@@ -62,6 +62,7 @@ static int quote_next_scalar;

 static const char* QUOTE_KEY_VALUES[] = {
    "tls_ca_path",
+   "tls_ca_file",
    "tls_cipher_list",
    "tls_ciphersuites",
    "appdata_dir",

saradickinson commented 3 years ago

Thanks for the report, sorry for breakage: fixed in https://github.com/getdnsapi/stubby/commit/34ca1af2e13771e917c31c2e545f33810489ea21

ubergeek77 commented 2 years ago

Can a new release be published with this patch applied? None of the package managers across all Linux distros include a fixed version of Stubby, because there have been no new releases since June 2021.

saradickinson commented 2 years ago

Yes - we are working on it and should be out in the next few weeks.