search

getdokan / dokan-migrator

3 stars 3 forks source link

Fix calculation when divided by zero. If anywhere, any value is divid… #23

Closed Aunshon closed 1 month ago

Aunshon commented 1 month ago

…ed by zero, there can be a fatal.

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve modifications to various methods across multiple files to enhance error handling and prevent division by zero errors in calculations related to shipping amounts, commission rates, and migration progress. Key adjustments include ensuring that divisor values default to 1 when associated arrays or totals are empty or invalid. These updates improve the robustness of financial calculations and shipping distributions within the order processing and migration logic.

Changes

Files Change Summary
includes/Helpers/MigrationHelper.php Updated split_parent_order_shipping to prevent division by zero by ensuring $vendors_count defaults to 1.
includes/Integrations/WcVendors/OrderMigrator.php Modified commission rate calculation in get_dokan_order_data to default subtotal to 1 if empty or less than one.
includes/Integrations/Wcfm/OrderMigrator.php Enhanced commission rate calculation and shipping logic in get_dokan_order_data and process_refund for robustness.
includes/Migrator/Manager.php Adjusted migration progress calculation in migrate method to default total_count to 1 if empty, preventing division errors.
dokan-migrator.php Updated plugin metadata including Plugin URI, Author, and Author URI for clarity and consistency.
readme.txt Changed bug report and feature request link to the new GitHub repository for issue tracking.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OrderMigrator
    participant MigrationHelper
    participant Manager

    User->>OrderMigrator: Request order data
    OrderMigrator->>OrderMigrator: Calculate commission rate
    OrderMigrator->>MigrationHelper: Split shipping costs
    MigrationHelper->>OrderMigrator: Return shipping distribution
    OrderMigrator->>User: Provide order data

    User->>Manager: Start migration
    Manager->>Manager: Calculate migration progress
    Manager->>User: Update migration status

🐇 "In the meadow, changes bloom,
With careful code, we clear the gloom.
Division by zero, a thing of the past,
Robust and steady, our functions will last.
With shipping and commissions now safe and sound,
Hops of joy for improvements abound!" 🐰

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 90872e0d540a035ceb9663198c5b24323a214d76 and 7acf3bc09e9e04b6dc1e46951fa39dc432c3899c.
Files selected for processing (2) * dokan-migrator.php (1 hunks) * readme.txt (1 hunks)
Files skipped from review due to trivial changes (2) * dokan-migrator.php * readme.txt
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.