getdokan / dokan

Multivendor marketplace platform
https://wordpress.org/plugins/dokan-lite/
257 stars 200 forks source link

SELLER PACKS SUBSCRIPTION - Dokan Subscription Cancelled email template - sent to admin -> should be sent on the day the user clicks on cancel #2044

Closed Sophie-2e closed 3 months ago

Sophie-2e commented 1 year ago

Bug Description

When vendors cancel their subscriptions, before upgrading/downgrading, the admin does not receive the Dokan Subscription Cancelled email template anymore.

Step To Reproduce

Go on a vendor dashboard > subscription > cancel your current subscription Check admin email > no email received

Expected Behaviour

When vendors cancel their subscriptions, before upgrading/downgrading, the admin should receive the Dokan Subscription Cancelled email template.

Actual Behaviour

When vendors cancel their subscriptions, before upgrading/downgrading, the admin does not receive the Dokan Subscription Cancelled email template anymore.

Additional Information

Use Stripe Express

Environment (please complete the following information)

1. Dokan Version: [3.9]
2. Dokan Pro Version: [3.9]
3. WooCommerce Version: [8.1.1]
4. Browser [all]
5. Current Theme: [all]
nurul-umbhiya commented 1 year ago

@Sophie-2e Couldn't reproduce this issue on our end. Kindly create a support ticket for this. They'll take care of it.

Sophie-2e commented 1 year ago

@nurul-umbhiya I already opened a customer support ticket: https://app.dokan.co/support/22323 and Yeasin did reproduce this error on his end too...according to him "We have already created an issue report on our side and anticipate that it will be resolved as soon as possible." which is why I opened the GitHub report, so I can be sure that it is really taking care of.

Waiting for your news.

Sophie-2e commented 1 year ago

Hello @nurul-umbhiya, So I understand how you can reproduce the error, instead of the admin receiving the notification on the day that the vendor has cancelled his subscription, the admin only knows it on the next billing cycle which is in my case every month, so I received the cancellation email today, while the vendor cancelled the subscription 3 weeks ago. Not practical for the admin who cannot make accurate prevision if he/she only knows on the next billing cycle day, nor try to contact the vendor to keep them on the platform.

Also weird that all subscriptions got cancelled today even though the vendor did subscribe to another pack so he has to resubscribe again which does not make sense as he already subscribed to a new pack 3 weeks ago which lasts for 1 year with a recurring payment every month. What is the expected behaviour when a vendor cancels a subscription and upgrades/downgrades right after?

Waiting for your news, Thanks

Sophie-2e commented 10 months ago

@nurul-umbhiya @imtiaz-pranto any update on this? Note that since last update I notice that all subscription cancelled are still being paid in Stripe so seller end up paying 3 subscription every month...but does not receive any email about this eccept the Dokan Shop Enabled email which is not about the order but the shop being enabled. Cf Customer Support ticket https://app.dokan.co/support/40285

Sophie-2e commented 8 months ago

@nurul-umbhiya @imtiaz-pranto reported since october, still not fix with latest updates and, since latest updates cannot subscribe to any recurrent packs with Stripe Express, still not able to renew, so still stuck on this. Stripe Express module need to be fix urgently. What is the timeline?

Sophie-2e commented 8 months ago

Hello @nurul-umbhiya , @imtiaz-pranto , now the subscription/renewal issue because of the compatibility issue with WPML is resolved, I could test this again. So the email is sent indeed, but instead of the admin receiving the notification on the day that the vendor has cancelled his subscription, the admin only knows it on the next billing cycle which is in my case every month, so I received the cancellation email today, while the vendor cancelled the subscription 3 weeks ago. Not practical for the admin who cannot make accurate prevision if he/she only knows on the next billing cycle day, nor try to contact the vendor to keep them on the platform. I will go ahead and change the title of this GitHub feature improvement request.

(This is NOT an emergency, there are other priorities ๐Ÿ˜‰)

MdAsifHossainNadim commented 6 months ago

@Sophie-2e Currently, we have been unable to reproduce the issue you reported to us. We kindly request that you watch the video resources provided for further clarification and re-examine the situation If the problem persists, please create a new support ticket and collaborate with our support team for detailed assistance.

If the issue is no longer reproducible on your end, please inform us accordingly so that we can proceed to close the issue.

Thank you for your cooperation and understanding.

Sophie-2e commented 6 months ago

@MdAsifHossainNadim @nurul-umbhiya @imtiaz-pranto I cannot shot a video because my subscriptions are renewed monthly so today I cancelled subscriptions and indeed admin did not received any email as the subscription will be fully cancelled in a month which mean the admin email will only be sent in a month. So I cannot shoot video to show what does not happen.

So you shot a video to show me what happens ont the D day when vendor cancels a monthly subscription. Show me the emails sent to the admin on the day the seller has cancelled his monthly subscription as apparently, you do receive an email if you say that you cannot reproduce this bug.

I opened the ticket #57385, your customer support team can do the test themselves too and send it to you. Will be waiting for your news.

MdAsifHossainNadim commented 6 months ago

@mr-gausulazam Vhai, kindly check this video & re-check the ticket. As we discussed this issue is not raising from the plugin end. Is this problem site-specific...???

Awaiting your reply...

Sophie-2e commented 6 months ago

Hey @MdAsifHossainNadim , I just redid a full test with Dokan 3.10.3. Note that I also use WPML. Whatever the language I don't receive the cancel email and I have some issues when sellers orders/cancel the subscription in another language than the default language. Please @mr-gausulazam send the video to @MdAsifHossainNadim so he can see all the tests with Dokan 3.10.3 and tell me how to fix it.

MdAsifHossainNadim commented 6 months ago

@mr-gausulazam @Sophie-2e Related with update: email refactor PR.

Sophie-2e commented 6 months ago

@MdAsifHossainNadim cannot access the private repository, did you get the full test video I sent on the 23rd of April to @mr-gausulazam made with Dokan 3.10.3?

To go faster, here is conversation with Gausul:

Gausul: We have detected an issue on your website and plugin level. The problem occurs when creating a free subscription plan with a price of 0. If you set any price for the subscription plan, the issue does not occur, and the email triggers properly. However, this issue only happens for the free subscription plan. Our team is actively working to resolve this issue. Once they resolve it, I will let you know.

Me: Would make sense that it is the default behaviour to not receive the cancel email on the 0 euro subscription because it is NOT a recurrent subscription, this is the only one that is NOT recurrent. So it is probably the default behaviour for non-recurrent subscriptions. But all the other paid subscriptions are recurrent and they are the ones that are supposed to receive the email right after the seller clicks on cancel but do not when sellers click on the cancel button. And they are at least 50 euros for the test in the video so it excludes your first supposition about the price.

So it has nothing to do with the 0 euro.

Please check again video and replicate the exact same test (seller dashboard language + packs) so you can successfully reproduce errors by yourself and start working on a resolution.

Sophie-2e commented 5 months ago

@MdAsifHossainNadim @mr-gausulazam the issue only occurs for recurring subscriptions so if you check non-recurring subscriptions, you will never reproduce the bug. Check with recurring subscriptions. Still waiting for your news.

mr-gausulazam commented 5 months ago

@MdAsifHossainNadim bhai, the email only sent to the English language. There is a need to multilingual support.

MdAsifHossainNadim commented 4 months ago

@Sophie-2e Could you please confirm, whether you are not receiving any email notifications when you cancel your subscription after setting a date for the pack validity from your product. If this is correct, kindly review the provided screencast and let me know your findingsโ€ฆ

If my understanding is incorrect, could you please provide a brief screencast demonstrating what you expect to happen...?

CC: @mr-gausulazam

Sophie-2e commented 4 months ago

@MdAsifHossainNadim as explained last time (https://github.com/getdokan/dokan/issues/2044#issuecomment-2106346897), you only get the issue with the recurring pack but you keep testing with a non-recurring pack. So when you do a test with a RECURRING PACK (which means that renews every week, month whatever, and that renews automatically for a certain period (one month, a year etc...), then you will have the error and so you will receive no email. Please @mr-gausulazam , I don't know how to explain that the issue ONLY happens with RECURRING subscription, can you translate my thought to your colleague then ๐Ÿ˜… Thanks for your help ๐Ÿ™Œ

And then what I expect, exactly like your screencast for a non-recurring subscription, so indeed to receive an email that the subscription has been cancelled. Recurring and non-recurring cancellations should trigger the same email. Just recheck this then: https://github.com/getdokan/dokan/issues/2044#issue-1933451768

mr-gausulazam commented 4 months ago

@Sophie-2e I have explained this to the @MdAsifHossainNadim bhai properly. I hope he will resolve it from our end.

MdAsifHossainNadim commented 4 months ago

@Sophie-2e Kindly check this screencast for recurring product cancellation email & follow up Subscription cancellation email PR for getting update.

Sophie-2e commented 4 months ago

Hello @MdAsifHossainNadim, thanks for the video, for the email that was sent in your video, I guess it is the one sent to the vendor that we see in your video but still not the one that is sent to the admin. 2 emails are supposed to be sent when vendor cancels subcription, one to seller, and one to admin. So not sure which one you do not receive but you also miss one in your test:

Here again, I tested when I cancel, I do not receive any email (nothing sent to the seller and nothing sent to the admin) but I don't use daily payment like you do, it is a monthly payment and recurring for a year, not sure if it could be the reason impacting the email not being sent: to see video ask @mr-gausulazam

The Dokan Support team (and @mr-gausulazam) has access to the staging website if you need to check it out there.

Will be waiting for your reply

Mohaiminulislam1989 commented 4 months ago

@MdAsifHossainNadim, @mr-gausulazam, Please check from your side.

Sophie-2e commented 3 months ago

Thank you so much for fixing this issue @MdAsifHossainNadim and @Mohaiminulislam1989 , just tested it with Dokan 3.10.4+ Pro 3.10.3, and it works like a charm now ๐Ÿ’ฏ You rock guys ! ๐ŸŽ‰