search

getdokan / dokan

Multivendor marketplace platform
https://wordpress.org/plugins/dokan-lite/
254 stars 200 forks source link

fix: Shop url rendered double slash when using WPML on vendor registration form. #2291

Closed MdAsifHossainNadim closed 2 months ago

MdAsifHossainNadim commented 3 months ago

All Submissions:

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

Fix: Shop URL rendered double slash when using WPML on vendor registration.

Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.

Before Changes

Go throw the issue details: Link

After Changes

image

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes improve URL handling and output security in two template files by introducing and utilizing $home_url and $custom_store_url variables. Additionally, esc_url is used to sanitize URLs, and printf is applied for regulated display of HTML content, enhancing maintainability and readability.

Changes

Files Change Summary
.../account/update-customer-to-vendor.php Initialized $home_url and $custom_store_url; used esc_url; replaced echo with printf
.../global/seller-registration-form.php Introduced $home_url and $custom_store_url for streamlined URL handling in the shop URL input

Assessment against linked issues

Objective Addressed Explanation
Disabled order editing option when the order status is cancelled or refunded (#59) ❓ No visible changes related to this issue.

Poem

In code we tread with care and pride,
URLs secure, no bugs to hide.
Echo replaced, conditions clear,
esc_url ensures no fear.
Our template's now a stronger shield,
With clarity and clean code wield.
코드랩비트, onward we cheer! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
shashwatahalder01 commented 3 months ago

Scenario: Double slash is rendering when using WPML on the vendor registration form

Steps to reproduce:

  1. translate my-account page
  2. go to translated page &
  3. fill shop URL

Screenshot:

Screenshot at Jul 01 10-48-02
shashwatahalder01 commented 3 months ago

Scenario: Double slash is rendering when using WPML on the vendor registration form created via dokan shortcode

Steps to reproduce:

  1. create a page with dokan shortcode [dokan-vendor-registration]
  2. translate the page
  3. go to the translated page &
  4. fill shop URL

Screenshot:

Screenshot at Jul 01 10-47-02
MdAsifHossainNadim commented 3 months ago

@shashwatahalder01 Brother, kindly let me know if any inconsistencies found.

Sophie-2e commented 2 months ago

@shashwatahalder01 @MdAsifHossainNadim does not work, please review test here: https://github.com/getdokan/dokan-wpml/issues/59#issuecomment-2233600772