Closed aihimel closed 2 months ago
The changes to the dokan_dashboard_nav
function in includes/functions-dashboard-navigation.php
involve preprocessing the keys for the navigation menu and submenu by applying rawurlencode_deep
to the results of the apply_filters
calls. This ensures that the keys are properly encoded, potentially addressing issues with special characters in URLs.
File | Change Summary |
---|---|
includes/functions-dashboard-navigation.php |
Applied rawurlencode_deep to filtered keys in the dokan_dashboard_nav function for menu and submenu navigation. |
sequenceDiagram
participant User
participant DashboardNavigation
participant Filter
User->>DashboardNavigation: Access dashboard navigation
DashboardNavigation->>Filter: Apply 'dokan_dashboard_nav_menu_key' filter
Filter-->>DashboardNavigation: Return filtered menu key
DashboardNavigation->>DashboardNavigation: rawurlencode_deep(filtered key)
DashboardNavigation->>Filter: Apply 'dokan_dashboard_nav_submenu_key' filter
Filter-->>DashboardNavigation: Return filtered submenu key
DashboardNavigation->>DashboardNavigation: rawurlencode_deep(filtered submenu key)
DashboardNavigation-->>User: Return encoded navigation keys
🐰 In lands of dashboard, keys did prance,
We bathed them deep in encode's dance.
Filters blend with careful art,
Keeping URLs smart,
Navigation’s tune, enhanced by chance. 🚀
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Active menu should be selected if translation language is changed @getdokan/plugin-qa .
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit